[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

Aurelien Jacobs aurel
Thu Jul 24 22:02:13 CEST 2008

Luca Abeni wrote:

> Luca Abeni wrote:
> [...]
> > I'll test h.264 (encoded through libavcodec + x264 with default options) in mp4,
> > mov, matroska, and flv. Is this enough, or should I add some more tests?
> Ok, here are the two possible patches (BTW, I just realized that the first one
> looked smaller because it only fixed the mov muxer, and did not fix the flv and
> mkv muxers...).

The patch passing a ByteIOContext to ff_avc_parse_nal_units() is better IMO.
It avoid one malloc/copy step for every packet.

The patch looks OK to me, except the reindent you did in the 3 encoders and
which should be applied as separate cosmetics:

> -    put_buffer(pb, pkt->data, size);
> [...]
> +        put_buffer(pb, pkt->data, size);


More information about the ffmpeg-devel mailing list