[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

[Alexander Strange]

On Jul 25, 2008, at 3:01 AM, Luca Abeni wrote:

> Hi Michael,
>
> Michael Niedermayer wrote:
> [...]
>>> I did not check if "make test" already tests these codec/muxer  
>>> combinations
>>> (h.264 in mp4, mov, mkv, and flv), but I think that it should...  
>>> So, someone
>>> should make sure that the "standard" regression tests already  
>>> cover this case,
>>
>> No h.264 encoder in ffmpeg no encoder/muxer tests with h264 in make  
>> test ...
>> ... unless we put a h264 video in svn :)
>
> I was thinking about some tests that are only enabled when ffmpeg is  
> configured
> with x264 support (or to an "h264test" target that only works when  
> x264 support
> is enabled).

x264's output changes frequently whenever there's an improvement in  
compression, and it would probably be a real pain to update the md5s  
all the time. It's better to just stick a sample video in svn, unless  
we only tested lossless mode.