[FFmpeg-devel] [PATCH] split-radix FFT

matthieu castet castet.matthieu
Tue Jul 29 21:09:30 CEST 2008

Michael Niedermayer wrote:
> On Tue, Jul 29, 2008 at 09:21:32PM +0300, Uoti Urpala wrote:
> Iam not strongly opposed to a patch that adds them one by one to the
> exported globals or cleanly splits header files into internal & external
> where this is not done yet and sets visibility per file.
> But i wont do it myself, id just review the patch!
> Also such a patch would not allow us to remove all the MANGLE() they still
> would be needed for forcing textrels on x86-32 and for old gcc versions.
For visibility stuff, I start something on 

The idea was to put in ffmpeg public header
#pragma GCC visibility push(default)
#pragma GCC visibility pop

in configure add some stuff to detect if the compiler support 
visibility, and if yes add to CFLAGS "-DIN_FFMPEG_BUILD 

But because there is some functions, that aren't in the public header, 
used across ffmpeg lib, we need to add one by one the remaining functions.

Do you like this idea ?


More information about the ffmpeg-devel mailing list