[FFmpeg-devel] [PATCH] split-radix FFT

Uoti Urpala uoti.urpala
Tue Jul 29 21:36:01 CEST 2008


On Tue, 2008-07-29 at 20:42 +0200, Michael Niedermayer wrote:
> Iam not strongly opposed to a patch that adds them one by one to the
> exported globals or cleanly splits header files into internal & external
> where this is not done yet and sets visibility per file.
> But i wont do it myself, id just review the patch!

Most of the changes should not be particularly hard. One question is the
syntax (macro names?) actually used for the declarations. I don't have
any particularly strong opinion about that at the moment.

> Also such a patch would not allow us to remove all the MANGLE() they still
> would be needed for forcing textrels on x86-32 and for old gcc versions.

Does using -fPIC but still forcing some textrels with MANGLE give some
real benefit over say compiling i386/ without -fPIC (which probably
wouldn't be too hard to set up)?





More information about the ffmpeg-devel mailing list