[FFmpeg-devel] [PATCH] Electronic Arts TGV decoder

[Reimar Döffinger]

On Tue, Jul 29, 2008 at 10:28:24PM +1000, pross at xvid.org wrote:
> On Sun, Jul 20, 2008 at 10:14:19PM +1000, pross at xvid.org wrote:
> > On Sun, Jul 20, 2008 at 10:04:44AM +0200, Reimar D?ffinger wrote:
> > > Hello,
> > > On Sun, Jul 20, 2008 at 12:28:06PM +1000, pross at xvid.org wrote:
> > > > On Sat, Jul 19, 2008 at 11:30:38AM +0200, Reimar D?ffinger wrote:
> > > > > The diff should be smaller if you change the order of these two
> > > > > functions.
> > > > 
> > > > Okay, but s/smaller/simpler/.
> > > 
> > > Why did you put the new function below lzo1x_decode? And no, I did mean
> > > smaller, the diff should basically consist of an additional { and a new
> > > function header + doxy and maybe a few more lines.
> > > Anything above that IMO needs an explanation why that would be needed.
> > > Oh well, I just did change it myself, see attached patch.
> > 
> > Thanks!
> 
> Reminar, were there any other comments, or should I just go ahead and
> commit?

Ok by me, though I did not test my lzo patch myself, and it would be
nice if you could do a quick benchmark with lzo.c compiled with -DTEST
to make sure it does not slow things down (too much).
Otherwise it might be better to make an additional function that is
forced to be inlined and call that from both the exported and the
internal one.

Greetings,
Reimar D?ffinger