[FFmpeg-devel] [PATCH] AAC Decoder round 4

Robert Swain robert.swain
Wed Jul 30 18:11:38 CEST 2008

2008/7/30 Michael Niedermayer <michaelni at gmx.at>:
> On Wed, Jul 30, 2008 at 05:06:52PM +0300, Kostya wrote:
>> On Wed, Jul 30, 2008 at 03:02:49PM +0200, Michael Niedermayer wrote:
>> > On Wed, Jul 30, 2008 at 01:54:16PM +0100, Robert Swain wrote:
>> [...]
>> > > Kostya has said that he would like these changes reverted as he uses
>> > > these elements of these data structures in his code.
>> >
>> > He can just put these 2 fields in the 2 structs back with his encoder patch.
>> > But as long as they are not used i will not approve unused variables, its
>> > far too hard to keep track of what might be used one day and then check back
>> > if that actually happened or if we ended up with some permamently unused
>> > fields in structs.
>> fine with me
>> I'd like to submit my encoder for review ASAP and it's hard to do without
>> stable (i.e. fully committed) AAC decoder in SVN.
> The AAC decoder is big, it will take time to reach svn even if i and robert
> try hard to move quickly ...
> But ill try to review AAC patches before others when there is one posted.

And I'll respond to the AAC patch reviews as quickly as I can. :)


More information about the ffmpeg-devel mailing list