[FFmpeg-devel] bit func helpers

Roman Shaposhnik rvs
Wed Jun 4 20:20:05 CEST 2008


On Mon, 2008-06-02 at 12:09 -0700, Baptiste Coudurier wrote:
> Baptiste Coudurier wrote:
> > Hi Michael,
> > 
> > Michael Niedermayer wrote:
> >> On Fri, May 30, 2008 at 02:00:22PM +0200, Andreas ?man wrote:
> >>> Hi
> >>>
> >>> I suggest we move these tiny helpers for dv.c to bitstream.h
> >> Code which is used just by dv stays in dv.
> >>
> >> If i disable dv, i dont want these compiled ...
> >> Besides the API is complex enough no need to add to it functions only used
> >> by a single codec.
> >>
> >> [...]
> >>
> >>> -static inline int get_bits_size(GetBitContext *s)
> >>> -{
> >>> -    return s->size_in_bits;
> >>> -}
> >> I really think dv should use s->size_in_bits instead of this senseless
> >> wraper function but iam not dv maintainer, just my 2 cents ...
> >>
> > 
> > Patch attached, Roman ok to apply ?
> > 
> 
> Roman ? :>

Sorry, I guess I missed the patch.

Thanks,
Roman.





More information about the ffmpeg-devel mailing list