[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

Michael Niedermayer michaelni
Thu Jun 5 02:43:37 CEST 2008


On Thu, Jun 05, 2008 at 02:30:57AM +0200, Michael Niedermayer wrote:
> On Wed, Jun 04, 2008 at 11:55:23PM +0100, Robert Swain wrote:
> > On 4 Jun 2008, at 21:56, Baptiste Coudurier wrote:
> > > Michael Niedermayer wrote:
> > >> On Wed, Jun 04, 2008 at 11:18:46AM -0700, Baptiste Coudurier wrote:
> > >>> Michael Niedermayer wrote:
> > >>>> On Wed, Jun 04, 2008 at 08:09:02AM -0600, Jason Garrett-Glaser  
> > >>>> wrote:
> > >>>>>> Id just tell users to use FULL if they mean FULL ...
> > >>>>> IMO for consistency with other x264 options "esa" should be  
> > >>>>> available,
> > >>>>> but it should just be an alias for full.  Takes minimal code and  
> > >>>>> makes
> > >>>> ok
> > >>>>
> > >>>> but IMHO ESA is not a logic abbreviation for full search, just me  
> > >>>> 2 cent
> > >>>>
> > >>>>
> > >>>>> the interface that little bit more user friendly, something that  
> > >>>>> is
> > >>>>> sorely needed with x264 encoding under ffmpeg.
> > >>>> People prefer complaining about problems than working on  
> > >>>> solutions ...
> > >>>>
> > >>> Well I do work on solutions :>
> > >>
> > >> Me too, ive a half finished per codec defaults change locally ...
> > >
> > > Awesome !
> > 
> > I made some patches for this that didn't quite work that used the  
> > 'wrong' approach. Baptiste said they should use AVOption instead but I  
> > was unaware of this API at the time and by the time I'd finished  
> > writing it only to be told it would need rewriting, I didn't have the  
> > motivation to fix it up. :)
> > 
> > If you want to look at what I did, they are patches 0001-0004* here:
> > 
> > http://www.swains.plus.com/superdump/ffmpeg/patches/
> > 
> > I would appreciate if you made what you've done available too as I may  
> > have some criticisms! :)
> 
> Code below,
> just put -vpre anime-hq on the command line and have a file with the path
> ~/.ffmpeg/mpeg4-anime-hq.ffpreset
> with all your AVOptoion key=value stuff in it
> similar for other codecs.
> 
> minor known bug, -vpre must be after -vcodec
> 
> Iam planning to commit the code if there are no objections ...

Also we can after that patch easily add support to automatically load
~/.ffmpeg/<codecname>-default.ffpreset if no -*pre are specified
If that is wanted, iam not sure though if it really is, specifying what one
wants with -vpre hq / -vpre fast / veryfast / ultrahq doesnt seem that hard.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080605/e21b190b/attachment.pgp>



More information about the ffmpeg-devel mailing list