[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

[Michael Niedermayer]

On Thu, Jun 05, 2008 at 10:27:46AM -0700, Baptiste Coudurier wrote:
> Hi guys,
> 
> Michael Niedermayer wrote:
> > On Thu, Jun 05, 2008 at 09:42:06AM +0100, Robert Swain wrote:
> >> 2008/6/5 Michael Niedermayer <michaelni at gmx.at>:
> >>> On Wed, Jun 04, 2008 at 11:55:23PM +0100, Robert Swain wrote:
> >>>> On 4 Jun 2008, at 21:56, Baptiste Coudurier wrote:
> >>>>> Michael Niedermayer wrote:
> >>>>>> Me too, ive a half finished per codec defaults change locally ...
> >>>>> Awesome !
> >>>> I made some patches for this that didn't quite work that used the
> >>>> 'wrong' approach. Baptiste said they should use AVOption instead but I
> >>>> was unaware of this API at the time and by the time I'd finished
> >>>> writing it only to be told it would need rewriting, I didn't have the
> >>>> motivation to fix it up. :)
> >>>>
> >>>> If you want to look at what I did, they are patches 0001-0004* here:
> >>>>
> >>>> http://www.swains.plus.com/superdump/ffmpeg/patches/
> >>>>
> >>>> I would appreciate if you made what you've done available too as I may
> >>>> have some criticisms! :)
> >>> Code below,
> >>> just put -vpre anime-hq on the command line and have a file with the path
> >>> ~/.ffmpeg/mpeg4-anime-hq.ffpreset
> >>> with all your AVOptoion key=value stuff in it
> >>> similar for other codecs.
> >>>
> >>> minor known bug, -vpre must be after -vcodec
> >>>
> >>> Iam planning to commit the code if there are no objections ...
> >> This is presets code, not per codec defaults, but it's good. :)
> > 
> > Well, defaults are one preset IMHO
> > It would be easy just to do the equivalent of '-vpre default' when no
> > other -vpre is specified.
> > I suspect that would be much simpler than your code, also defaults would
> > be in a user editable file and not bloat the library itself ...
> > 
> 
> I had the idea that some codecs would need to override default
> AVOptions, more specifically min and max ranges, like libx264 or dnxhd
> for qmin/qmax.
> 
> For example DNxHD supports qmax up to 1024, and FFmpeg cannot use this

> possibility atm (needed to encode /dev/random for example), should I add
> bump qmax max value to 1024 ?

yes


> 
> We might add a mechanism where codecs could override ranges and default
> value.

yes ...

but ranges depend on more than just the codec, they also depend on other
values, not every combination is always allowed.

Simply adding a AVCodec.check_values() could check all that ...
the presets suggested by me could handle defaults ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080605/153bcb5d/attachment.pgp>