[FFmpeg-devel] Separating from nellymoserdec.c parts required by encoder

[Michael Niedermayer]

On Thu, Jun 05, 2008 at 09:56:15PM +0200, Bartlomiej Wolowiec wrote:
> Hi,
> Because I write nellymoser encoder as part of GSOC, I thought that some 
> functions should be moved from nellymoserdec.c to nellymoser.c.
> I wonder, should I use ff_nelly_ prefixes or full (but in my long) 
> ff_nellymoser_ ?
[...]
> Index: libavcodec/nellymoser.c
> ===================================================================
> --- libavcodec/nellymoser.c	(wersja 13656)
> +++ libavcodec/nellymoser.c	(kopia robocza)
> @@ -1,10 +1,11 @@
>  /*
> - * NellyMoser audio decoder
> + * Common code between Nellymoser encoder and decoder
>   * Copyright (c) 2007 a840bda5870ba11f19698ff6eb9581dfb0f95fa5,
>   *                    539459aeb7d425140b62a3ec7dbf6dc8e408a306, and
>   *                    520e17cd55896441042b14df2566a6eb610ed444
>   * Copyright (c) 2007 Loic Minier <lool at dooz.org>
>   *                    Benjamin Larsson
> + * Copyright (c) 2008 Bartlomiej Wolowiec

Maybe you should add your name after you have added significant code.
I do not consider mere spliting significant and already complained
to others (xiaohui) about the same ...
For the encoder you write its of course perfectly correct to have your
name there, but the common code was already there before you, just in
a different file

Besides this, your patch looks ok, if the maintainer/mentor agrees

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080606/aabd265c/attachment.pgp>