[FFmpeg-devel] [PATCH] Add versioning information to dlls

[Diego Biurrun]

On Fri, Jun 06, 2008 at 08:06:21PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Tue, Jun 03, 2008 at 09:48:29AM -0400, Jeremy Kolb wrote:
> >> 
> >> Diego Biurrun wrote:
> >> > On Mon, Jun 02, 2008 at 01:21:15PM -0400, Jeremy Kolb wrote:
> >> >   
> >> >> Diego Biurrun wrote:
> >> >>     
> >> >>> On Fri, May 30, 2008 at 03:37:53PM -0400, Jeremy Kolb wrote:
> >> >>>   
> >> >>> I'm out of bright ideas right now.  Let's wait for Mans to return from
> >> >>> LinuxTag and have a look.  In the meantime, could you please post the
> >> >>> latest incarnation of your patch so that we have a basis to work with?
> >> >>>       
> >> >> Here you go.
> >> >
> >> > Here's the relevant IRC discussion between me and Mans on the subject:
> >> >
> >> > 00:36 <@DonDiego> mru: did you see that windows rc thing?
> >> > 00:37 <@mru> I saw it, didn't look at it
> >> > 00:37 <@mru> in detail
> >> > 00:37 <@mru> this is the wrong solution
> >> > 00:37 <@mru> what we should do is
> >> > 00:37 <@mru> 1. fix version.h creation to work when building in subdirs
> >> > 00:38 <@DonDiego> yes
> >> > 00:38 <@mru> 2. add a %.o: %.rc rule
> >> > 00:38 <@mru> 3. add a %.rc: whatever rule
> >> > 00:38 <@mru> perhaps with a shell script helper
> >> > 00:39 <@DonDiego> we can start with 1.
> >> > 00:39 <@DonDiego> IIUC this is a real bug anyway
> >> > 00:39 <@mru> yes, that's why I gave it that number
> >> >
> >> > That does indeed sound like a plan.
> >> 
> >> Which part is incorrect?
> >
> > We need separate patches.  The first step would be to send us one that
> > implements version.h creation when running make from a subdirectory.
> > This is not entirely trivial, if you want to avoid having one version.h
> > file per subdirectory.  Try having configure run version.sh at the end
> > so that version.h already exists when make is run, even from a
> > subdirectory.
> 
> That's not a good idea, since the version can change without configure
> being run.

Let me say it more explicitly: We could have configure run version.sh at
the end in *addition* to version.sh being run from the Makefiles as
usual.  This would ensure that version.h exists before Make is invoked.

Diego