[FFmpeg-devel] [PATCH] Factorize in ffmpeg.c the options context setting

Stefano Sabatini stefano.sabatini-lala
Sun Jun 8 16:43:35 CEST 2008


On date Sunday 2008-06-08 15:41:22 +0200, Michael Niedermayer encoded:
> On Sun, Jun 08, 2008 at 03:35:29PM +0200, Stefano Sabatini wrote:
> > On date Sunday 2008-06-08 14:38:11 +0200, Michael Niedermayer encoded:
> > > On Sun, Jun 08, 2008 at 12:37:24PM +0200, Stefano Sabatini wrote:
> > > > Hi, as in subject, regression test passed.
> > > > 
> > > > Regards.
> > > > -- 
> > > > FFmpeg = Furious and Fucking MultiPurpose EntanGlement
> > > 
> > > > Index: ffmpeg.c
> > > > ===================================================================
> > > > --- ffmpeg.c	(revision 13707)
> > > > +++ ffmpeg.c	(working copy)
> > > > @@ -2684,6 +2684,22 @@
> > > >      return codec->id;
> > > >  }
> > > >  
> > > 
> > > > +/**
> > > > + * Sets in \p ctx all the options set in \p opts_ctx for all the \p
> > > > + * ctx options for which opt->flags & \p flags == flags is true.
> > > > + */
> > > > +static void set_context_opts(void *ctx, void *opts_ctx, int flags)
> > > 
> > > I know what the function does, but i do not understand the doxy above,
> > > i think thats not good.
> > 
> > I agree, I'm trying harder with the attached patch.
> 
> Could you send a patch without the doxy? :)

Here it is...

Regards.
-- 
FFmpeg = Fast and Fucking Merciless Portable ExchanGer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: factorize-ffmpeg-ctx-opts-setting-02.patch
Type: text/x-diff
Size: 6816 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080608/43d7134c/attachment.patch>



More information about the ffmpeg-devel mailing list