[FFmpeg-devel] [PATCH] add E-AC-3 support to AC-3 decoder

[Michael Niedermayer]

On Tue, Jun 17, 2008 at 05:36:38PM -0400, Justin Ruggles wrote:
> Michael Niedermayer wrote:
> > On Sat, Jun 07, 2008 at 10:30:31AM -0400, Justin Ruggles wrote:
> >> Hi,
> >>
> >> Here is a patch set to incrementally add support for E-AC-3 to the AC-3
> >> decoder.  There are 32 total patches.  I'm just attaching them all in
> >> this email instead of doing the git-send-email thing.
> >>
> > [...]
> >> +
> >> +#include "avcodec.h"
> >> +#include "ac3.h"
> >> +#include "ac3_parser.h"
> >> +#include "ac3dec.h"
> >> +#include "ac3dec_data.h"
> >> +
> >> +/** Channel gain adaptive quantization mode */
> >> +typedef enum {
> >> +    EAC3_GAQ_NO =0,
> >> +    EAC3_GAQ_12,
> >> +    EAC3_GAQ_14,
> >> +    EAC3_GAQ_124
> >> +} EAC3GaqMode;
> >> +
> >> +#define EAC3_SR_CODE_REDUCED  3
> >> +
> >> +static int idct_cos_tab[6][5];
> >> +
> >> +static int gaq_ungroup_tab[32][3];
> >> +
> > 
> >> +void ff_eac3_log_missing_feature(AVCodecContext *avctx, const char *log){
> >> +    av_log(avctx, AV_LOG_ERROR, "%s is not implemented. If you want to help, "
> >> +            "update your FFmpeg version to the newest one from SVN. If the "
> >> +            "problem still occurs, it means that your file has extension "
> >> +            "which has not been tested due to a lack of samples exhibiting "
> >> +            "this feature. Upload a sample of the audio from this file to "
> >> +            "ftp://upload.mplayerhq.hu/incoming and contact the ffmpeg-devel "
> >> +            "mailing list.\n", log);
> >> +}
> > 
> > I think this should be in utils.c it could be used by non ac3 as well
> 
> That's fine.  Should the text be changed then?  For E-AC3 the reason for
> unimplemented features is pretty much solely due to lack of samples.
> For unimplemented features in other codecs, that may not be the case.  I
> just want to be sure this text is okay before inviting people to upload
> samples which we may already have plenty of, but that we have simply not
> implemented for whatever reason.

add a int want_sample and put the second part under if(want_sample) or split
it in 2 functions ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080618/1687bd3e/attachment.pgp>