[FFmpeg-devel] [PATCH] AAC Decoder - Round 2.

[Michael Niedermayer]

On Sat, Jun 21, 2008 at 09:32:17PM +0100, Robert Swain wrote:
> 2008/6/20 Michael Niedermayer <michaelni at gmx.at>:
> > On Thu, Jun 19, 2008 at 04:22:57PM +0100, Robert Swain wrote:
> > [...]
> >> +        case ID_CPE:
> >> +            err = !ac->che[ID_CPE][tag] ? -1 : decode_cpe(ac, &gb, tag);
> >> +            break;
> >> +        case ID_FIL:
> >> +            if (tag == 15) tag += get_bits(&gb, 8) - 1;
> >> +            while (tag > 0)
> >> +                tag -= extension_payload(ac, &gb, tag);
> >> +            err = 0; /* FIXME */
> >> +            break;
> >> +        case ID_PCE:
> >> +            err = program_config_element(ac, &gb);
> >> +            break;
> >> +        case ID_DSE:
> >> +            err = data_stream_element(ac, &gb, tag);
> >> +            break;
> >> +        case ID_CCE:
> >
> >> +            err = !ac->che[ID_CCE][tag] ? -1 : decode_cce(ac, &gb, tag);
> >> +            break;
> >> +        case ID_LFE:
> >> +            err = ac->che[ID_LFE][tag] && !decode_ics(ac, &gb, 0, 0, &ac->che[ID_LFE][tag]->ch[0]) ? 0 : -1;
> >
> > maybe iam too tired but these appear hard to read, maybe a if() and some \n
> > would help
> 
> Does the attached help at all? 

yes, patch ok


> If you don't want the ternary code
> changing to if() else then just the \n between each case seems to help
> me.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080622/62f93c01/attachment.pgp>