[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding
Wed Jun 25 06:10:13 CEST 2008
2008/6/25 Diego Biurrun <diego at biurrun.de>:
> On Tue, Jun 24, 2008 at 11:24:17PM +0700, Vladimir Voroshilov wrote:
>> 2008/6/18 Diego Biurrun <diego at biurrun.de>:
>> > TTBOMK both are synonyms. I would prefer delay, which is the more
>> > common and more technical term and AFAICT it is used everywhere else.
>> > Go for delay.
>> I didn't touch filename, though.
>> "acelp_pitch_delay" sounds too long for me
>> If you wish and there are no more fixes in the file i can rename it too.
> Yes, please rename it, it's just two characters more and using "delay"
> everywhere and calling the file "lag" is confusing and silly.
>> + * M - ma prediction order
Now it is "MA (Moving Average) prediction order"
>> + * Predicted fixed codebook gain gc_p is computed using from
>> + * known as predicted energies:
> "The predicted..."
> But this is very confusing. What are you trying to say by "using from
> known as"?
'make checkheaders' also fixed in this file.
Fix for other files will be sent in separate thread.
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 12440 bytes
Desc: not available
More information about the ffmpeg-devel