[FFmpeg-devel] [PATCH] dct-test compile fix

[Diego Biurrun]

On Wed, Jun 25, 2008 at 03:01:26AM +0000, Jacob Meuser wrote:
> On Wed, Jun 25, 2008 at 02:50:19AM +0100, M?ns Rullg?rd wrote:
> > Jacob Meuser <jakemsr at sdf.lonestar.org> writes:
> > 
> > > On Wed, Jun 25, 2008 at 01:54:05AM +0200, Diego Biurrun wrote:
> > >> 
> > >> That hint is not enough, I need to be told what is wrong, I don't have
> > >> access to an OpenBSD system for testing.  Patches are also welcome.
> > >
> > > $OpenBSD: patch-configure,v 1.18 2008/01/26 01:56:02 jakemsr Exp $
> > > --- configure.orig	Fri Jun 20 19:40:11 2008
> > > +++ configure	Sat Jun 21 18:28:29 2008
> > > @@ -1213,9 +1213,9 @@ case $target_os in
> > >          disable need_memalign
> > >          LIBOBJFLAGS='$(PIC)'
> > >          SHFLAGS='-shared'
> > > -        SLIBNAME='$(SLIBPREF)$(FULLNAME)$(SLIBSUF).$(LIBVERSION)'
> > > -        SLIBNAME_WITH_VERSION='$(SLIBNAME)'
> > > -        SLIBNAME_WITH_MAJOR='$(SLIBNAME)'
> > > +        #SLIBNAME='$(SLIBPREF)$(FULLNAME)$(SLIBSUF).$(LIBVERSION)'
> > > +        #SLIBNAME_WITH_VERSION='$(SLIBNAME)'
> > > +        #SLIBNAME_WITH_MAJOR='$(SLIBNAME)'
> > >          oss_demuxer_extralibs="-lossaudio"
> > >          oss_muxer_extralibs="-lossaudio"
> > >          ;;
> > >
> > > without patching that out, make dies with something like:
> > >
> > > can't find target for libpostproc.so.
> > >
> > > I ended up just changing the default SLIBNAME* variables, which
> > > worked.
> > 
> > Well, what values did you assign them?
> 
> --- configure.orig	Fri Jun 20 19:40:11 2008
> +++ configure	Sat Jun 21 18:28:29 2008
> @@ -965,7 +965,7 @@ SLIBPREF="lib"
>  SLIBSUF=".so"
>  SLIBNAME='$(SLIBPREF)$(FULLNAME)$(SLIBSUF)'
>  SLIBNAME_WITH_VERSION='$(SLIBNAME).$(LIBVERSION)'
> -SLIBNAME_WITH_MAJOR='$(SLIBNAME).$(LIBMAJOR)'
> +SLIBNAME_WITH_MAJOR='$(SLIBNAME).$(LIBVERSION)'
>  LIB_INSTALL_EXTRA_CMD='$(RANLIB) "$(LIBDIR)/$(LIBNAME)"'
>  
>  # gcc stupidly only outputs the basename of targets with -MM
> 
> but I am also now overriding LIBVERSION.  I made this change after
> getting past the problem.

Send a clean patch which assigns the correct library name under OpenBSD.

> > > @@ -1756,7 +1763,7 @@ fi
> > >
> > >  texi2html -version > /dev/null 2>&1 && enable texi2html || disable texi2html
> > >
> > > -check_type sys/socket.h socklen_t
> > > +check_type sys/types.h socklen_t
> > >
> > >  ##########################################
> > >  # Network check
> > >
> > > simply stated, socklen_t is defined in sys/types.h
> > 
> > POSIX disagrees:
> > 
> >   The <sys/socket.h> header shall define the type socklen_t
> 
> ok, so?  this is what I meant by these changes are "hacks" that aren't
> "correct".  this one isn't a big deal anyway.

So why don't you fix the system header?  Is that such a big deal?

Diego