[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

[Michael Niedermayer]

On Wed, Jun 25, 2008 at 04:18:54PM +0200, Reinhard Tartler wrote:
> 
> Michael Niedermayer <michaelni at gmx.at> writes:
> > My objection is that it bloats the lib, causes us work, does not move
> > ffmpeg forward and may lead to all kinds of obscure bugs. The code has
> > not been designed with the consideration that both scalers might be enabled
> > at the same time.
> 
> Do you *know* about breakage or is this pure speculation?

speculation
And i do not like code in svn that iam unsure of if it is correct. Especially
if i have noone who is willing to maintain the code.


> 
> > If we drop the old API everyone is forced to switch to the new one.
> 
> Except that some downstreams don't. In debian we collect packages that
> break beacuse of this here:
> 
> http://bugs.debian.org/cgi-bin/pkgreport.cgi?users=pkg-multimedia-maintainers at lists.alioth.debian.org&tag=img-convert
> 
> Patches are welcome of course. If you know about more packages affected
> by this issue, please tag them accordingly (or notify me to do that).
> 

> > -> so this patch is strictly more work for us as well as everyone at average
> >    than droping the old API.
> 
> Distros like Mandriva, Debian, Ubuntu etc have to do this additional
> work then. Which is unfortunate because package maintainers do not have
> the knowledge to properly maintain that patch.

I can understand that distros do not like to maintain the patch, but I
do neither want to maintain it!
So what was it that you wanted?
You want one of us to maintain your patch which is too much work for you to
do?
Applying the patch to svn would not help you at all if noone maintains it
and we just tell users not to enable both scalers at the same time.
I think if distros want both scalers enabled at the same time in the same
lib, its the distros who should maintain that mess.

We can leave things as they are or we can bump the major version number and
remove the old API and other accumulated junk.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/1fe1b0da/attachment.pgp>