[FFmpeg-devel] [PATCH] Fix mm_flags, mm_support for ARM

Michael Niedermayer michaelni
Thu Jun 26 21:52:57 CEST 2008


On Thu, Jun 26, 2008 at 08:59:43PM +0200, matthieu castet wrote:
> Laurent Desnogues wrote:
>> On Thu, Jun 26, 2008 at 5:24 PM, Michael Niedermayer <michaelni at gmx.at> 
>> wrote:
>>> On Thu, Jun 26, 2008 at 04:45:04PM +0200, Laurent Desnogues wrote:
>>>> On Thu, Jun 26, 2008 at 3:05 PM, Michael Niedermayer <michaelni at gmx.at> 
>>>> wrote:
>>>>> I dont see what good this patch could do
>>>> As I said in my original mail, the aim was only to be able to
>>>> build dct-test on ARM without linking failures.
>>> but the patch wont achive that when HAVE_IWMMX or what it was called, is 
>>> set
>> Humph, silly me, you are right...  That's why my previous patch
>> was always defining mm_support.  Anyway let's forget all of
>> that, and wait for NEON support first and we'll see what makes
>> sense at that moment :-)
> Well it could be interesting to put current arm dct in dct-test
> Here a patch that does that using the fact that 13967 remove mm_flags.
>
>
> Matthieu

> Index: libavcodec/dct-test.c
> ===================================================================
> --- libavcodec/dct-test.c	(r?vision 13991)
> +++ libavcodec/dct-test.c	(copie de travail)
> @@ -63,6 +63,10 @@
>  extern void fdct_altivec (DCTELEM *block);
>  //extern void idct_altivec (DCTELEM *block);?? no routine
>  
> +// ARM
> +extern void j_rev_dct_ARM (DCTELEM *block)  ;
> +extern void simple_idct_ARM (DCTELEM *block) ;
> +extern void simple_idct_armv5te (DCTELEM *block) ;
>  
>  struct algo {
>    const char *name;
> @@ -113,6 +117,13 @@
>    {"BFINfdct",        0, ff_bfin_fdct,       fdct, NO_PERM},
>    {"BFINidct",        1, ff_bfin_idct,       idct, NO_PERM},
>  #endif
> +#ifdef ARCH_ARMV4L
> +  //{"IDCT_ARM",        1, j_rev_dct_ARM,      idct, /* what perm to set here */},
> +  {"IDCT_SIMPLEARM",  1, simple_idct_ARM,    idct, NO_PERM},
> +#ifdef HAVE_ARMV5TE
> +  {"SIMPLEARMV5TE",   1, simple_idct_armv5te,idct, NO_PERM},
> +#endif
> +#endif
>  
>    { 0 }
>  };

that part is ok



> @@ -523,6 +534,9 @@
>             "-4          test IDCT248 implementations\n");
>  }
>  
> +#ifndef mm_support
> +#define mm_support() 0
> +#endif
>  int main(int argc, char **argv)
>  {
>      int test_idct = 0, test_248_dct = 0;

this one is not

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080626/40911da5/attachment.pgp>



More information about the ffmpeg-devel mailing list