[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding
Sat Jun 28 20:34:24 CEST 2008
2008/6/29 Michael Niedermayer <michaelni at gmx.at>:
> On Sat, Jun 28, 2008 at 08:09:38AM +0700, Vladimir Voroshilov wrote:
>> 2008/6/28 Michael Niedermayer <michaelni at gmx.at>:
>> > On Fri, Jun 27, 2008 at 09:59:49PM +0700, Vladimir Voroshilov wrote:
>> >> I have question about rounding. What is better:
>> >> (a >> 13)<<10
>> >> or
>> >> (a>>3) & ~0x3ff
>> >> ?
>> >> Such code is required for bitexactness.
>> > i prefer the &~ variant
>> Here is it.
> looks ok
nice. will commit soon.
> About the rest of the g729 code, will you split out furter parts?
> Or should i review it as it is?
Hm.. The rest are g.729 core, g.729 postfilter and g729d all
are in separate patches. I'll post updated patches in their threads.
Did i understand you right?
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
More information about the ffmpeg-devel