[FFmpeg-devel] [PATCH] fix wc3 xan decoder

Mike Melanson mike
Sat Mar 1 23:19:28 CET 2008

Michael Niedermayer wrote:
> not in the patch, the patch works around it by setting data[0] to zero
> dont copy it and it will be zero (from release_buffer)
> That is i think your patch is a hack not a fix :)

I have been looking at the problem some more. For this codec, I need to
keep the previous frame data for MC. Right now, I have data structures
for current and previous frames allocated as part of the codec's private
structure. Should I turn those into structure pointers that are
allocated and freed during _init() and _end() functions?

Or should I not bother to keep the previous AVFrame structure and
instead keep the data stashed in a private buffer, and also reget the
same frame each time?

Or something else? :) xan.c is not the only video decoder that follows
this pattern and I will probably need to fix the others.

	Thanks for your advice on this matter...
	-Mike Melanson

More information about the ffmpeg-devel mailing list