[FFmpeg-devel] [PATCH] fix unused variable warning in faanidct.c

mark cox melbournemark+ffmpeg
Wed Mar 5 14:13:00 CET 2008


On Wed, Mar 5, 2008 at 11:48 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Wed, Mar 05, 2008 at 11:40:04PM +1100, mark cox wrote:
> > On Wed, Mar 5, 2008 at 11:33 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> >
> > > On Wed, Mar 05, 2008 at 11:07:58PM +1100, mark cox wrote:
> > > > On Wed, Mar 5, 2008 at 10:56 PM, Michael Niedermayer <
> michaelni at gmx.at>
> > > > wrote:
> > > >
> > > > > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox wrote:
> > > > > > $subj
> > > > >
> > > > > rejected, mixing declaraions and statements
> > > > >
> > > >
> > > > fixed.
> > >
> > > Now it wont compile anymore with the alternative rotation as the
> variable
> > > would be missing.
> > >
> >
> >
> > There is no compile switch to enable #if 0.! Those variables are only
> used
> > within #if 0 block.
>
> Before your patch the #if 0 block did work if one changed the 0 to a 1
> afterwards the "user" would have to debug it first.
>
> if you want to get rid of the warning add a unused attribute
>

Like attached?

Regards,
mark


>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> it is not once nor twice but times without number that the same ideas make
> their appearance in the world. -- Aristotle
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHzpapYR7HhwQLD6sRAquPAKCINjOvsJz+NnkvAHf8CievJ3Nr2gCfS31g
> o8lLAzBEQKV+UZtQriz5960=
> =xQGz
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: faan_unused_variable_try3.diff
Type: text/x-diff
Size: 1140 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080306/5472786a/attachment.diff>



More information about the ffmpeg-devel mailing list