[FFmpeg-devel] [PATCH] fix unused variable warning in faanidct.c

Michael Niedermayer michaelni
Wed Mar 5 15:28:04 CET 2008


On Thu, Mar 06, 2008 at 12:13:00AM +1100, mark cox wrote:
> On Wed, Mar 5, 2008 at 11:48 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > On Wed, Mar 05, 2008 at 11:40:04PM +1100, mark cox wrote:
> > > On Wed, Mar 5, 2008 at 11:33 PM, Michael Niedermayer <michaelni at gmx.at>
> > > wrote:
> > >
> > > > On Wed, Mar 05, 2008 at 11:07:58PM +1100, mark cox wrote:
> > > > > On Wed, Mar 5, 2008 at 10:56 PM, Michael Niedermayer <
> > michaelni at gmx.at>
> > > > > wrote:
> > > > >
> > > > > > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox wrote:
> > > > > > > $subj
> > > > > >
> > > > > > rejected, mixing declaraions and statements
> > > > > >
> > > > >
> > > > > fixed.
> > > >
> > > > Now it wont compile anymore with the alternative rotation as the
> > variable
> > > > would be missing.
> > > >
> > >
> > >
> > > There is no compile switch to enable #if 0.! Those variables are only
> > used
> > > within #if 0 block.
> >
> > Before your patch the #if 0 block did work if one changed the 0 to a 1
> > afterwards the "user" would have to debug it first.
> >
> > if you want to get rid of the warning add a unused attribute
> >
> 
> Like attached?

If you move the unused vars to their own line then yes.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080305/191dac35/attachment.pgp>



More information about the ffmpeg-devel mailing list