[FFmpeg-devel] [PATCH] QT RLE header parser refactoring

Michael Niedermayer michaelni
Tue Mar 11 17:15:31 CET 2008

On Mon, Mar 10, 2008 at 09:01:32PM -0700, Mike Melanson wrote:
> Mike Melanson wrote:
>> Yeah. I didn't like the idea either, to be honest. :) I have better
>> ideas for refactoring I'll try next.
> Here's my next idea. This is not a final draft; it's just a prototype to 
> see if I'm going in the right direction. For the 8-bit decoding case, I 
> moved the header parsing code into the main decode function and passed 3 
> extra parameters into the 8-bit decoding function. There's a lot of cruft 
> in this one but that would go away in the final draft.

Yes, the header parsing should be factored as well. So yes this is the right

And after that the bpp sould be passed into the function instead of having
a dozen functions.

And then the AVPalette stuff should be cleaned up
Then the CHECK_STREAM_PTR / CHECK_PIXEL_PTR should be removed and
a minimum of checks be implemented cleanly.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080311/51d8a4cb/attachment.pgp>

More information about the ffmpeg-devel mailing list