[FFmpeg-devel] [PATCH] robustify parsing of flv metadata

Pascal Massimino pascal.massimino
Tue Mar 18 22:53:59 CET 2008


  Michael,

On Tue, Mar 18, 2008 at 2:44 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Tue, Mar 18, 2008 at 02:33:24PM -0700, Pascal Massimino wrote:
> >   Gents,
> >
> >  a little patch to prevent non-sense num_val in broken
> >  metadata packets. Maybe it's better to bail out in such
> >  cases, dunno for sure.
>
> Doesnt work, num_val is double and can after casting to int still be
> nonsense.

 oh indeed! we should be testing ((int)num_val >= 0) instead...

>
> Also thanks for the sample to test unwrap-diff ;)


ok ok, will prepare an updated patch and be a good attaching citizen :)

skal


>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Thouse who are best at talking, realize last or never when they are wrong.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFH4De9YR7HhwQLD6sRAl1AAJ0aSapll9KDybXZPgDnSMaOKaU5LgCeJWm6
> tut8xqR1JWsRymDzDnwijcA=
> =cbfp
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>




More information about the ffmpeg-devel mailing list