[FFmpeg-devel] [PATCH] robustify parsing of flv metadata

Michael Niedermayer michaelni
Wed Mar 19 01:55:32 CET 2008


On Tue, Mar 18, 2008 at 03:02:04PM -0700, Pascal Massimino wrote:
>  Hi,
> 
> On Tue, Mar 18, 2008 at 2:53 PM, Pascal Massimino <
> pascal.massimino at gmail.com> wrote:
> 
> >   Michael,
> >
> > On Tue, Mar 18, 2008 at 2:44 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> >
> > > On Tue, Mar 18, 2008 at 02:33:24PM -0700, Pascal Massimino wrote:
> > > >   Gents,
> > > >
> > > >  a little patch to prevent non-sense num_val in broken
> > > >  metadata packets. Maybe it's better to bail out in such
> > > >  cases, dunno for sure.
> > >
> > > Doesnt work, num_val is double and can after casting to int still be
> > > nonsense.
> >
> >  oh indeed! we should be testing ((int)num_val >= 0) instead...
> >
> > >
> > > Also thanks for the sample to test unwrap-diff ;)
> >
> >
> > ok ok, will prepare an updated patch and be a good attaching citizen :)
> >
> 
> here, *attached*

ok

btw skal, if you want an svn write account, you can have one, just tell diego
a username.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080319/37a11630/attachment.pgp>



More information about the ffmpeg-devel mailing list