[FFmpeg-devel] [PATCH] RTSP alternate protocol 2-3/3

Michael Niedermayer michaelni
Wed Mar 19 03:29:26 CET 2008


On Tue, Mar 18, 2008 at 10:24:43PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Mar 18, 2008 at 10:14 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > > @@ -1001,6 +1005,10 @@
> > >      return 0;
> > >
> > >  fail:
> > > +    if (i < rt->nb_rtsp_streams && rtsp_st->rtp_handle) {
> >
> > how can i >= rt->nb_rtsp_stream be here ?<https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel>
> 
> 
> That's just for thew theoretical case that it's zero, in that case rtsp_st
> is unassigned and could segfault, this prevents that. Not sure if it can
> actually happen...

rtsp_st is the wrong thing to use anyway, rt->rtsp_streams looks better

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080319/9330b595/attachment.pgp>



More information about the ffmpeg-devel mailing list