[FFmpeg-devel] [PATCH] fix compilation (was Re: r12489 broke all builds)

Zuxy Meng zuxy.meng
Wed Mar 19 04:08:56 CET 2008


Hi,

2008/3/19, Benoit Fouet <benoit.fouet at purplelabs.com>:
> Michael Niedermayer wrote:
> > On Tue, Mar 18, 2008 at 12:22:41PM -0400, Alexander Strange wrote:
> >
> >> On Mar 18, 2008, at 12:13 PM, Mike Melanson wrote:
> >>
> >>> Check FATE:
> >>>
> >>>  http://fate.multimedia.cx/
> >>>
> >>> --
> >>>     -Mike Melanson
> >>>
> >> Missing include in rational.h.
> >>
> >
> > ok
> >
> >
>
> as already mentionned, I'll let Zuxy apply this one along with his patch.
> again, sorry for this bad commit :(

I should have run a distclean before building and sending the patch.
Anyway now we have 3 ways to fix the build:

1. Include "common.h" in "rational.h"
2. Include "common.h" in "mpeg12data.h"
3. Include "common.h" in "mpeg12data.c"

The only .c file that failed to compile is mpeg12data.c. All other
files that use "rational.h" have included "common.h" either directly
or indirectly.

Maybe Diego can point to me the cleanest approach?
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6




More information about the ffmpeg-devel mailing list