[FFmpeg-devel] [PATCH] set HAVE_MMX2 in config.h

Diego Biurrun diego
Sat Mar 22 19:16:02 CET 2008


On Wed, Mar 19, 2008 at 03:30:52PM +0100, Michael Niedermayer wrote:
> On Wed, Mar 19, 2008 at 09:41:57AM -0400, Alexander Strange wrote:
> > On Wed, Mar 19, 2008 at 9:02 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >
> > > On Wed, Mar 19, 2008 at 01:08:03AM -0400, Alexander Strange wrote:
> > >  >
> > >  > This patch generates the right asm by making a new LOCAL_MANGLE().
> > >  >
> > >  > I tested it on 64-bit, but it turns out fast_bilinear crashes there
> > >  > whether or not the patch is applied, unless you run it under valgrind.
> > >  > Don't have time to debug it.
> > >
> > >  > --- libavutil/internal.h      (revision 12497)
> > >  > +++ libavutil/internal.h      (working copy)
> > >  > @@ -120,11 +120,13 @@
> > >  >
> > >  >  // Use rip-relative addressing if compiling PIC code on x86-64.
> > >  >  #if defined(ARCH_X86_64) && defined(PIC)
> > >  > -#    define MANGLE(a) EXTERN_PREFIX #a"(%%rip)"
> > >  > +#    define LOCAL_MANGLE(a) "" #a "(%%rip)"
> > >  >  #else
> > >  > -#    define MANGLE(a) EXTERN_PREFIX #a
> > >  > +#    define LOCAL_MANGLE(a) "" #a
> > >  >  #endif
> > >
> > >  why the "" ?
> > 
> > Not needed, I misunderstood cpp syntax.
> 
> ok

Applied.

Diego




More information about the ffmpeg-devel mailing list