[FFmpeg-devel] Update: IFF 8SVX Demuxer Patch rev2

Diego Biurrun diego
Sun Mar 23 13:08:04 CET 2008


On Sun, Mar 23, 2008 at 12:30:07PM +0000, Jai Menon wrote:
> 
> I'll wait for your comments.
> 
> --- libavformat/iff.c	(revision 0)
> +++ libavformat/iff.c	(revision 0)
> @@ -0,0 +1,219 @@
> +/*
> + * IFF (.iff) File Demuxer

Here and in lots of other places: Please do not capitalize all words.

> + * Copyright (c) 2008 The ffmpeg Project

The FFmpeg project is not a legal entity.

> +    while(!done)
> +    {
> +      chunk_id = get_le32(pb);

Use 4 spaces indentation.

Also, you have tabs and trailing whitespace in your patch.

Diego




More information about the ffmpeg-devel mailing list