[FFmpeg-devel] [PATCH] code to parse mpeg4audio extradata

Michael Niedermayer michaelni
Wed Mar 26 23:41:07 CET 2008

On Wed, Mar 26, 2008 at 10:14:47PM +0100, Andreas ?man wrote:
> Michael Niedermayer wrote:
> > On Wed, Mar 19, 2008 at 04:54:03PM +0100, Baptiste Coudurier wrote:
> >> Hi,
> >>
> >> Here is a patch that adds parsing of mpeg4audio extradata, and retrieve
> >> needed infos for decoders (only mp3on4 atm, but will be needed for aac),
> >> and will be used by mov demuxer ideally to correctly compute sample rate
> >> and channels.
> >> Also extract common mpeg4audio code from aac_parser.c.
> > 
> > Iam fine with this in priciple but i am unsure if the code does not maybe
> > rather belong to libavformat.
> If the AAC decoder should reuse the code i don't think it could belong
> in lavf.

Please elaborate
my idea was that the mp4 demuxer would use this code to extract the various
thing from the mp4 atoms in .mp4 and set things like sample_rate,...
But maybe i misunderstood something?


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080326/aa358962/attachment.pgp>

More information about the ffmpeg-devel mailing list