[FFmpeg-devel] [PATCH] IFF demuxer and 8SVX decoder
Thu Mar 27 21:19:24 CET 2008
Michael Niedermayer wrote:
>> +static int iff_probe(AVProbeData *p)
>> + const uint8_t *d = p->buf;
>> + if (AV_RL32(d) == ID_FORM)
>> + return AVPROBE_SCORE_MAX;
>> + return 0;
> this is insufficient, it also applies to wc3 files
> see libavformat/wc3movie.c
I know; I'm a bad influence and set a bad example. :) But wc3movie.c
actually checks for a total of 8 magic bytes, not just 4.
And yeah, checking for 'FORM' is bad form (heh) since so many formats
used that. Bytes 8-11 carried the sub-type.
In light of the recent FLIC problem, should we start requiring even more
sanity checks from our demuxers?
More information about the ffmpeg-devel