[FFmpeg-devel] [PATCH] Non-recursive makefiles

Balatoni Denes dbalatoni
Fri Mar 28 19:00:39 CET 2008


Hi!

Maybe I misunderstand something, but ...

Friday 28 March 2008 03:02-kor M?ns Rullg?rd ezt ?rta:
> +$(SUBDIR)$(SLIBNAME): $(SUBDIR)$(SLIBNAME_WITH_MAJOR)
> +???????$(LN_S) $(SLIBNAME_WITH_MAJOR) $$@

if I am not mistaken, things like this won't work, when this rule is included 
several times in the toplevel Makefile, because only the last value of 
$(NAME) at the end of parsing the makefile - and hence 
$(SLIBNAME_WITH_MAJOR) - will be used in the command -- and not the value of 
$(NAME) and $(SLIBNAME_WITH_MAJOR) at the time of parsing the rule&command.

There should be a rule specific variable used, like:

$(SUBDIR)$(SLIBNAME): SHELLPARAM:=$(SLIBNAME_WITH_MAJOR)

$(SUBDIR)$(SLIBNAME): $(SUBDIR)$(SLIBNAME_WITH_MAJOR)
       $(LN_S) $(SHELLPARAM) $$@

bye
Denes




More information about the ffmpeg-devel mailing list