[FFmpeg-devel] Flac encoder and MPEG4 ALS

Michael Niedermayer michaelni
Sat Mar 29 14:32:33 CET 2008

On Sat, Mar 29, 2008 at 06:49:30PM +0000, Jai Menon wrote:
> Hi,
> I started some basic work on the MPEG4 ALS encoder and I get the feeling that 
> I could reuse a lot of code from the flac encoder. So (hypothetically ;-)) if 
> I were to submit a patch, is it okay if I move some code out of flacenc.c to 
> a shared source file? 

Of course! Code duplication is always bad ...
Note though that moving code must be in seperate patches, never in a patch
which does functional changes to any code.
Also note svn cp for spliting files while preserving history with svn.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080329/f7f2fc2e/attachment.pgp>

More information about the ffmpeg-devel mailing list