[FFmpeg-devel] [Ffmpeg-devel] [PATCH] GSM-MS decoder and encoder

[Michel Bardiaux]

Baptiste Coudurier wrote:
> Michel Bardiaux wrote:
>> Baptiste Coudurier wrote:
>>> Hi,
>>>
>>> Michel Bardiaux wrote:
>>>> Baptiste Coudurier wrote:
>>>>> Michel Bardiaux wrote:
>>>> [time for a big snip]
>>>>>> Michael has reported 13200 in aiff, do you also see 13200 for mov? Then 
>>>>>> accepting (OK, silently) 0, 13000 and 13200 when decoding solves your 
>>>>>> problem while leaving some safety.
>>>>> Yes.
>>>> OK then, my proposition is that on decoding, all 3 are accepted 
>>>> silently, anything else causes a warning (but is accepted); on encoding, 
>>>> anything else than 13000 elicits a warning and is forced to 13000.
>> Ok with this spec, or is it necessary to tolerate 13200 on encoding too 
>> because some muxer sets 13200 before init is called?
> 
> Well you can check in the code, that is mov and aiff, I guess.

You wrote in another thread (in reply to my proposal to make checks 
dependednt on strictness):
 > Yes, and now I'd like your check being done when stricness is explicitly
 > asked :>
 >

That modifies things:
Default: encoding: silently accepts 13200. I still think a warning for 
other values would be good.
Strict: encoding: anything else than 13000 and *maybe* 13200 rejected.
	For 13200, I still have to see in mov and aiff.
Default: decoding: accepts anything silently.
Strict: decoding: reject others than 13000 13200.

Greetings,
-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/