[FFmpeg-devel] [PATCH] Escape 124 (RPL) decoder rev5

Mike Melanson mike
Mon Mar 31 19:42:24 CEST 2008


Uoti Urpala wrote:
> On Mon, 2008-03-31 at 18:57 +0200, Michael Niedermayer wrote:
>> On Mon, Mar 31, 2008 at 09:50:55AM -0700, Mike Melanson wrote:
>>> Reimar D?ffinger wrote:
>>>> Actually, for gcc and (IIRC) icc, declaring it as an array of size 0
>>>> works too. It does not work for Sun CC, so I guess it is not legal C...
>>> This will be a problem when we get Sun CC up and running for FATE. Then
>>> again, was FFmpeg previously known to work with Sun CC?
>> If its not valid C (can someone confirm this?) then ill change it to [1]
>> Anyway actually eli should fix this ...
> 
> Neither [0] nor [1] is valid considering the code as a whole; [] is the
> correct alternative. However an array declaration of size 0 is always
> invalid even when considered in isolation (the standard says "shall have
> a value greater than zero" for the relevant case of array declaration).

I have a crazy idea: Declare block as (MacroBlock*) and allocate that
member of a statically-allocated CodeBook structure.

-- 
	-Mike Melanson




More information about the ffmpeg-devel mailing list