[FFmpeg-devel] [PATCH] unscaled float 2 int conversion

Benjamin Larsson banan
Sat May 3 16:17:57 CEST 2008

Michael Niedermayer wrote:
> On Sat, May 03, 2008 at 02:34:55PM +0200, Benjamin Larsson wrote:
>> $topic
>> While this might not be the fastest method, this could be useful in some
>> cases. For example when it is not trivial and cheap to convert the
>> floats to the proper representation. The wma decoder is one of those cases.
> I dont know what you are talking about, wma is a normal MDCT codec and i dont
> see why it would require a seperate float2int16 routine.
> Either this is better for all MDCT codecs or none.

Well when I tried the last time I did't get it to work, there was some
overlap issue that wasn't trivial to sort out. Anyway I don't like this
scaling stuff to much as it complicates the code and only old platforms
might have benefited from it. And if/when we get a new audio api going
then it complicate matters if codecs are allowed to output scaled samples.

> And benchmarks would be required as well to see if this is faster or slower
> than the extra + 384 or what it was.

The wma patch is a resend on an ok'd patch from before.

Anyway, I would like to use this unscaled function for the dca decoder
that currently is broken when not using simd. I don't really care about
the wma code but this would be nice to have for dca.

Benjamin Larsson

More information about the ffmpeg-devel mailing list