[FFmpeg-devel] [PATCH] Print AV_NOPTS_VALUE in seek test

Ramiro Polla ramiro
Mon May 5 18:35:37 CEST 2008


Ramiro Polla wrote:
> Michael Niedermayer wrote:
>> On Thu, May 01, 2008 at 09:28:37PM +0100, Ramiro Polla wrote:
>>> Hello,
>>> Attached patch makes seek_test print AV_NOPTS_VALUE instead of some big 
>>> negative and apparently meaningless number.
>> Complicating the code for no apparent reason, the regression tests are
>> just for developers knowing what they do. And someone not knowing what
>> the big meaningless number is wont be able to make any sense of
>> "AV_NOPTS_VALUE" either.
> Seek test fail on MinGW because MSVCRT doesn't properly printf() big 
> numbers. Instead of printing
> pts:-102481911520608.625000
> it prints
> pts:-102481911520608.600000

Could you please reconsider this?
Seek tests with latest MinGW CVS only fail because of this printf. The 
tests don't really fail, but the way the results are printed do. This 
can easily be avoided in FFmpeg's side by writing cleaner output.

Attached patch prints out -1 instead of AV_NOPTS_VALUE.

Ramiro Polla
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: seek_test_2.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080505/fe0f55ec/attachment.asc>

More information about the ffmpeg-devel mailing list