[FFmpeg-devel] [PATCH] Enhance ffmpeg.c:opt_default()

Michael Niedermayer michaelni
Tue May 13 02:16:11 CEST 2008

On Mon, May 12, 2008 at 11:53:48PM +0200, Stefano Sabatini wrote:
> Hi all,
> actually opt_default() will keep trying to set an option even if it
> fails to set it in some context.
> The correct (or a more correct behaviour) seems to simply give up when
> the option is found the first time but its value is invalid for that
> context, in this case the program immediatly exits.
> Also the patch make opt_default() distinguishes if an option wasn't
> found in all the checked contexts or if the option was found in some
> context but its value was invalid.

Nice so the patch does nothing except making the code more complex?
patch rejected

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080513/bf7f0bdd/attachment.pgp>

More information about the ffmpeg-devel mailing list