[FFmpeg-devel] Invalid and inefficient vfw-avi packed B frames?detected

[Michael Niedermayer]

On Mon, Nov 03, 2008 at 07:21:37PM +0300, Andrew Savchenko wrote:
> Hi,
> 
> On Monday 03 November 2008 18:49, Andrew Savchenko wrote:
> > Hi,
> >
> > On Monday 03 November 2008 15:02, Michael Niedermayer wrote:
> > > On Sun, Nov 02, 2008 at 10:39:01PM -0500, compn wrote:
> >
> > [...]
> >
> > > > yes, it gets 2x annoying when using -demuxer lavf
> > > > since you get the demuxer message too.
> > >
> > > WARNING is correct, DEBUG is not correct, you can check
> > > libavutil/log.h for the definition of both.
> > > If someone sends a patch that makes it printed just once per
> > > file i dont mind approving that but just because its common
> > > doesnt mean its not a warning or wont possibly cause problems.
> >
> > What about the following patch?
> 
> This one should be without cosmetics.
[...]

> --- libavcodec/h263dec.c.orig	2008-11-03 18:33:30.000000000 +0300
> +++ libavcodec/h263dec.c	2008-11-03 18:33:44.000000000 +0300
> @@ -53,6 +53,7 @@
>      s->low_delay= 1;
>      avctx->pix_fmt= PIX_FMT_YUV420P;
>      s->unrestricted_mv= 1;
> +    s->invalid_b_frames=0;
>  
>      /* select sub codec */
>      switch(avctx->codec->id) {

this should be unneeded


> --- libavcodec/mpegvideo.h.orig	2008-11-03 18:06:11.000000000 +0300
> +++ libavcodec/mpegvideo.h	2008-11-03 18:25:07.000000000 +0300
> @@ -487,6 +487,7 @@
>      /* H.263 specific */
>      int gob_index;
>      int obmc;                       ///< overlapped block motion compensation
> +    int invalid_b_frames;           ///< flag for invalid and inefficient B-frames detected

int showed_packed_warning; ///< flag for having shown the warning about divxs invalid b frames

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081103/575a0e57/attachment.pgp>