[FFmpeg-devel] [PATCH] Fix potential av_find_opt() crash if context is NULL

Stefano Sabatini stefano.sabatini-lala
Sun Nov 9 18:27:52 CET 2008

On date Sunday 2008-11-09 16:29:21 +0100, Michael Niedermayer encoded:
> On Sun, Nov 09, 2008 at 03:44:43PM +0100, Stefano Sabatini wrote:
> > Currently sws_opts is declared as extern in cmdutils.h and defined in
> > cmdutils.c, then used in the ff*.c tools, so the variable *does* exist
> > semantically for every application, with or without
> it does not exist _semantically_ in the sense that 0 has no logarithm.

Uh, pretty weird definition of semantical existence ;-). 

> [...]
> > I'm not sure, but I remember vaguely that in some older
> > libavfilter-soc version sws_opts declaration and use was under an #if
> > 
> > After your patch which moved opt_default() and *_opts to
> > cmdutils.[ch], in oder to get the same effect we should patch
> > cmdutils.[ch], which as I already wrote I don't think is a good idea.
> when libavfilters scale filter will be included in svn then ALL WITHOUT
> EXCEPTION references to sws_opts will be removed at the same time.
> before this happens sws_opts will be initialized!

OK, thanks for your patience. 

FFmpeg = Furious and Forgiving Mind-dumbing Power Exxagerate Generator

More information about the ffmpeg-devel mailing list