[FFmpeg-devel] usage of Requires.private in *.pc files

[Måns Rullgård]

Reinhard Tartler <siretart at tauware.de> writes:

> M?ns Rullg?rd <mans at mansr.com> writes:
>
>> Reinhard Tartler <siretart at tauware.de> writes:
>>
>>> M?ns Rullg?rd <mans at mansr.com> writes:
>>>
>>>>> In detail: I need to know how and in what way libavcodec exposes
>>>>> implementation details (structures, enums, etc) of libraw1394, dirac,
>>>>> theora, vorbisenc. I believe avcodec does not at all, but I want to be
>>>>> sure.
>>>>
>>>> It does not.
>>>
>>> In that case I propose this patch:
>>>
>>> ===================================================================
>>> --- configure   (Revision 15797)
>>> +++ configure   (Arbeitskopie)
>>> @@ -2360,11 +2360,11 @@
>>>  Name: $name
>>>  Description: $comment
>>>  Version: $version
>>> -Requires: $(disabled shared && echo $requires)
>>> -Requires.private: $(enabled shared && echo $requires)
>>> +Requires:
>>> +Requires.private:
>>
>> Are those empty declarations really needed?
>
> I don't think so. Leaving them out would have broken consistency;

Consistency is never an excuse for doing something suboptimal.

> Conflicts is already an empty field.

Then send a patch to fix that instead.

> Anyways, leaving them in and empty emphasises that they are empty on
> purpose (and the line shows up in 'svn blame')

Remove them if they are not needed.

>> I will not approve any change to the .pc files until at least two
>> other people who actually use them on different distros have confirmed
>> that the change doesn't break anything.
>
> Okay, I will test this patch in Debian and Ubuntu then.

I'd like to get a comment from someone else as well, preferably
someone using an unrelated distro.

-- 
M?ns Rullg?rd
mans at mansr.com