[FFmpeg-devel] [PATCH] QCELP decoder

Michael Niedermayer michaelni
Tue Nov 11 16:42:02 CET 2008

On Tue, Nov 11, 2008 at 04:17:55PM +0100, Diego Biurrun wrote:
> On Sun, Nov 09, 2008 at 02:03:39PM -0300, Reynaldo H. Verdejo Pinochet wrote:
> > 
> > this is the kind of changes I'd like to see out of the 'merging'
> > attempt and back as patches against the SoC code, I don't have your
> > gifted sight, I get lost. Merging the soc code with cosmetic fixes
> > into HEAD and latter working on these functional changes would be OK
> > too.
> I'm not sure I understand what you want, but the priority should be
> merging code to FFmpeg.  The SoC repo is just a sandbox.  I don't see
> what we would gain from improving it.

I think i do understand reynaldos intent, i think his idea is to
check that no bugs/issues have been introduced between soc and the
patches kenan is posting now. And i agree that it does make sense to
check these changes, i just dont see an easy way to do it now without
delaying the merging effort.
I guess the best is still if reynaldo reviews kenans svn of the code,
assuming he has the time, will and interrest to do that.

The "problem" here is somewhat unique as we have 2 people with 2 trees
who have not been active at the same time.

Had both been active at the same time, changes would have been cross
reviewed by each other as they where commited.
Had only one been active, there would be noone complaining, though of
course that wouldnt really be better ...
Had both worked in the soc tree, reynaldo now could just go over the
svn log postings and reply where needed ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081111/d54b3d5b/attachment.pgp>

More information about the ffmpeg-devel mailing list