[FFmpeg-devel] [PATCH] fixes in mpeg audio parsing

Michael Niedermayer michaelni
Thu Nov 13 19:47:24 CET 2008


On Thu, Nov 13, 2008 at 06:59:17PM +0200, Yoav Steinberg wrote:
[...]
> > One certainly could have concatenated 2 mp3 files with a id3v1 ending in
> > the middle it would be nice if the parser & decoder would skip/ignore this
> > trash in the middle.
> > To me it seem that it shouldnt be too hard to make the parser skip
> > this, unless a valid id3v1 tag can also be a valid mp3 frame.
> > 
> 
> The current parser will, in most cases, skip id3v1 tags in the stream 
> which is good. But in one case the parser does actually think the tag is 
> part of a frame and does not skip it. This is when the tag was put 
> inside (overwriting) a frame's data. This isn't strictly valid, but it 
> turns out there are such files out there.

so, fix the parser

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081113/0312bb95/attachment.pgp>



More information about the ffmpeg-devel mailing list