[FFmpeg-devel] [PATCH] QCELP decoder

Reynaldo H. Verdejo Pinochet reynaldo
Sat Nov 15 01:31:28 CET 2008


Kenan Gillet wrote:
> if it is not one of those, then we should have an I_F_Q.
> The SoC code determined the framerate by looking at the bufsize
> and then had a warning if the framerate byte (1st byte of the frame)
> differed.
> I suppose it was to handle frame which would not contain this first byte.
> I have not seen any files with such a feature though, and neither
> Reynaldo [1].
> We could simplify to just looking at the framerate and checking
> that the buffer contains enough data for the corresponding rate.
> what do you think?
> Renaldo, any thought on this one?

Well, I said this before but I will stress it further, my way
of thinking is stated in the code: My opinion is that if you
can, doing a little effort and at a reasonable cost, account
for an unexpected mistake then you should. that's what I did.

Reynaldo H. Verdejo Pinochet

More information about the ffmpeg-devel mailing list