[FFmpeg-devel] [PATCH][COSMETICS] to merged QCELP decoder code

Reynaldo H. Verdejo Pinochet reynaldo
Sat Nov 15 21:35:30 CET 2008

Hi there Diego

Diego Biurrun wrote:
>> +    for(i=0; i<length; i++)
> I think it's more readable with spaces around the operators.

Totally subjective on my part but it gets tiresome
when typing/programming. I'm quite used to put
spaces after punctuation marks so the one after the
';' comes out naturally.

>> -    for (i = 0; i < 4; i++)
>> -        if (gain[i]) {
>> +    for(i=0; i<4; i++)
>> +    {
>> +        if(gain[i])
>> +        {
> Judging from what I've seen around here I think the preferred style
> keeps the opening brace on the same line as the if/for.

I find it easier to read if brackets are vertically
aligned and I like the added almost-blank line
provided by the lonely bracket separating the
conditional statement. Of course I'd change it if
its actually an style rule but if not forcibly mandated
I'd naturally choose what better suits me as the file's

Reynaldo H. Verdejo Pinochet

More information about the ffmpeg-devel mailing list