[FFmpeg-devel] [PATCH/RFC] change function prototype of parse_sdp_a_line

Luca Abeni lucabe72
Mon Nov 17 20:55:40 CET 2008


Ronald S. Bultje wrote:
> Hi,
> long subject / separate thread to attract attention from the Lucas,
> after our previous discussions.
> So, here's what I have: RDT is integrated now (mostly). The SDP
> contains lines like this (uncut):
> The problem is that I need to create and access these streams when I
> need them. I create them in the parse_sdp_a_line callback in rdt.c,
> and that I currently do in the ff_real_parse_sdp_a_line() function
> (this is the *server*-specific SDP line parsing, not the *RTP
> payload*-specific SDP line parsing), which therefore has access to a
> AVFormatContext. That is already in SVN.

I just looked at current svn, and I did not find any 
ff_real_parse_sdp_a_line... Either "svn update" is failing here, or 
there is some other problem or misunderstanding somewhere.

Anyway, I still think that passing an AVFormatContext to a routine that 
parses a media attribute is confusing at least. And I believe that 
calling av_new_stream() both when parsing an "m=" line and when parsing 
an "a=" line is not a good idea, too.
But I give up, and I'll leave this discussion to the rtsp maintainer.


More information about the ffmpeg-devel mailing list