[FFmpeg-devel] Unaligned arrays in snow.c

Uoti Urpala uoti.urpala
Sun Nov 23 18:19:10 CET 2008


On Sun, 2008-11-23 at 17:00 +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Sat, Nov 22, 2008 at 10:46:14PM +0000, M?ns Rullg?rd wrote:
> >> 
> >> A few functions in snow.c declare arrays on the stack, which are then
> >> passed to dsputil functions requiring 16-byte alignment.  Searching
> >> for "FIXME align" finds them.  This is crashing on ARM.
> >> 
> >> What is the correct fix for this?
> >
> > Move them into the context
> 
> The size is variable.
> 
> > or use the align #defines (and fix the compiler if needed)
> 
> You know that doesn't work for alignment > 8, and you know that fixing
> the compiler is close to impossible.

Shouldn't this be done for x86 (and possibly other platforms) where the
compiler does work anyway?





More information about the ffmpeg-devel mailing list