[FFmpeg-devel] [PATCH] recover from truncated aiff

[Maksym Veremeyenko]

Baptiste Coudurier ???????(??):
[...]
> In general, avoiding seek is better in case of non streamable input, 
so the first version of patch is preferable?

> also if av_get_packet returns < requested, it means that it reached eof, 
> so there is no need to seek back since the last sample will not be 
> decoded anyway.
patch with seek back was done to avoid ffmpeg behavior after such patch 
applying.

First patch provides recovery for /behavior/ and /data/ provided, so 
further decoder will not know that file is truncated, second version 
attempt to save all possible samples, but further decoders (pcm.c in my 
case) still return error on wrong packet (that is less then sample size)...

> 
> It seems this issue is also present in raw.c and wav.c
I can try prepare such patches for that demuxer, but i need to know the 
way to fix the problem (see above about patches methods)

> 
> See thread:
> "[FFmpeg-devel] [patch] 6 channel raw audio input results in invalid	PCM 
> packet error", for a related problem, Im not saying that your patch is 
> wrong though.
I will check this.

> 
> No need to check for eof, just ensure pkt->size is a block_align multiple.
> 
OK, thanks for hint!

-- 
________________________________________
Maksym Veremeyenko