[FFmpeg-devel] Bug report : build problem with "configure --disable-encoders"

Michael Niedermayer michaelni
Tue Nov 25 18:24:07 CET 2008


On Tue, Nov 25, 2008 at 09:29:28AM +0100, David Geldreich wrote:
> Hello Diego,
>
> Le 25 nov. 08 ? 09:12, David Geldreich a ?crit :
>
>> Le 25 nov. 08 ? 00:03, Diego Biurrun a ?crit :
>>
>>> Michael will cut my head off if I apply this as one, so please send a
>>> patch just for the rename and another to move the tables.
>>
>> Here is a patch with only moving the aan tables from mpegvideo_enc.c to 
>> specific files : aandcttab.c/.h
>>
>> Notice in the Makefile, the aandcttab.o have been added only to encoder 
>> (mpegvideo_enc) and decoder (eatgq) that needs it.
>>
>> I also updated the "doxygen comment"
>
> Here are the 2 patches which should be applied in the order move then 
> rename variables.
>
> ann_move.diff replaces the previous patch (error in the doxygen comment)
>
> They both pass "make test" and "make checkheaders" on my Intel Mac (OSX 
> 10.5.5, gcc 4.0.1)
[...]
> --- ./libavcodec/aandcttab.c	2008-11-25 09:18:43.000000000 +0100
> +++ /Users/dgeld/src/ffmpeg/libavcodec/aandcttab.c	2008-11-25 09:18:50.000000000 +0100
> @@ -23,7 +23,7 @@
>  
>  #include "aandcttab.h"
>  
> -const uint16_t aanscales[64] = {
> +const uint16_t ff_aan_scales[64] = {
>      /* precomputed values scaled up by 14 bits */
>      16384, 22725, 21407, 19266, 16384, 12873,  8867,  4520,
>      22725, 31521, 29692, 26722, 22725, 17855, 12299,  6270,
> @@ -35,7 +35,7 @@ const uint16_t aanscales[64] = {
>      4520 ,  6270,  5906,  5315,  4520,  3552,  2446,  1247
>  };
>  
> -const uint16_t ff_inv_aanscales[64] = {
> +const uint16_t ff_aan_inv_scales[64] = {

i would prefer if you wouldnt rename ff_inv_aanscales at least not in the
same patch that adds ff_ to aanscales

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081125/8e39a68e/attachment.pgp>



More information about the ffmpeg-devel mailing list