[FFmpeg-devel] [PATCH] recover from truncated aiff

Maksym Veremeyenko verem
Wed Nov 26 12:21:59 CET 2008


Michael Niedermayer ???????(??):
> On Wed, Nov 26, 2008 at 10:46:53AM +0200, Maksym Veremeyenko wrote:
[...]
>>      /* note: we need to modify the packet size here to handle the last
>>         packet */
>> -    pkt->size = ret;
>> +    if((st->codec->block_align > 1) && (ret % st->codec->block_align)) {
>> +        pkt->size -= pkt->size % st->codec->block_align;
>> +        av_log(s, AV_LOG_WARNING, "truncated packet detected, dropped %d bytes\n", ret - pkt->size);
>> +    }
>> +
>>      return ret;
> 
> iam against this patch, its not the job of the wav demuxer to truncate its
> data
According to that statement, all patches for wav, aiff and raw have no 
sense? Am i correct?

What method is preferable to fixing issue with truncated file contains 
broken sample? Fixing pcm.c?


-- 
________________________________________
Maksym Veremeyenko




More information about the ffmpeg-devel mailing list